>>> On 13.11.18 at 14:39, <igor.druzhi...@citrix.com> wrote:
> On 13/11/2018 10:46, Jan Beulich wrote:
>> Writes to such pages would need to be handed to the emulator, which we're
>> not prepared to do at this point.
>>
>> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>>
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -2556,7 +2556,8 @@ static void *_hvm_map_guest_frame(unsign
>>
>> if ( writable )
>> {
>> - if ( unlikely(p2m_is_discard_write(p2mt)) )
>> + if ( unlikely(p2m_is_discard_write(p2mt)) ||
>> + unlikely(p2mt == p2m_ioreq_server) )
>
> Shouldn't we introduce p2m_is_ioreq_server() for consistency and use it
> everywhere?
I think such abstractions help if multiple types are to be covered;
I don't mind them to be used also for single types, but I don't
thinks that's overly important. Plus doing so is of course unrelated
to this series, as other checks using == already exist.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
