>>> On 14.11.18 at 21:40, <rcojoc...@bitdefender.com> wrote: > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -2282,6 +2282,34 @@ bool_t p2m_altp2m_lazy_copy(struct vcpu *v, paddr_t > gpa, > return 1; > } > > +static void p2m_reset_altp2m(struct domain *d, unsigned int idx, > + bool reset_remapped, bool free_logdirty_ranges)
Especially the call sites are quite ugly to read with two booleans like these. Did you consider introducing an unsigned int flags parameter instead, with suitable symbols constants #define-d to make visible at the call sites what behavior is wanted? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
