On 15/11/2018 13:52, Andrew Cooper wrote: > This ends up corrupting L1's view of RFLAGS by setting ZF. The correct value > is established earlier in the function.
vmsucceed() doesn't set any flags, only clears some. And in this function it's just redundant. ZF is set by VMfailValid. So I think the description must be changed. -- Sergey > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger....@citrix.com> > CC: Sergey Dyasli <sergey.dya...@citrix.com> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.com> > --- > xen/arch/x86/hvm/vmx/vvmx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c > index 41c4e2f..a72b519 100644 > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -1371,7 +1371,6 @@ static void virtual_vmexit(struct cpu_user_regs *regs) > nvmx_update_apicv(v); > > nvcpu->nv_vmswitch_in_progress = 0; > - vmsucceed(regs); > } > > static void nvmx_eptp_update(void) > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
