On 22/11/2018 15:44, Jan Beulich wrote: >>>> On 21.11.18 at 14:21, <andrew.coop...@citrix.com> wrote: >> Seemingly, a majority of users either override the helpers anyway, or have an >> mfn_t in their hands. >> >> Update the API, and adjust all users to match. In some places, use the >> unsigned long variant in places where we are interacting with an external >> struct and there is no chance of them switching to mfn_t. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> > > Some of the changes to trace.c look as if you were fixing an address > truncation bug, but allocations appear to be done with a respective > width restriction.
The ABI uses 32bit integers for MFNs. The interface is undocumented and uses raw arrays of integers. It is borderline impossible to follow. The correct way to do this would be to use the new resource mapping API, but its not something I've got time to do in the short or medium term. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
