On 30/11/2018 09:23, Jan Beulich wrote: >>>> On 29.11.18 at 20:20, <andrew.coop...@citrix.com> wrote: >> get_cpuid_domain_info() has two conflicting return styles - either -error for >> local failures, or -1/errno for hypercall failures. Switch to consistently >> use -error. >> >> While fixing the xc_get_cpu_featureset(), take the opportunity to remove the >> redundancy and move it to be adjacent to the other featureset handling. > Having noticed the redundancy before, I was assuming this was done > to prevent altering host_nr_features early, just in case future code > additions would want to use its original value. The way it is now, the > code folding looks correct.
I don't recall a deliberate intention to do that, but it was a long time ago now. > >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> Thanks. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
