>>> On 03.12.18 at 17:18, <andrew.coop...@citrix.com> wrote: > For gen-cpuid.py, fix a comment describing self.names, and generate the > reverse mapping in self.values. Write out INIT_FEATURE_NAMES which maps a > string name to a bit position. > > For parse_cpuid(), introduce a slightly fuzzy strcmp() to accept changes in > punctuation, and perform a binary search over INIT_FEATURE_NAMES. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger....@citrix.com> > > Slightly RFC, because I'm not entirely certain if this is a good idea or > not.
It is a good idea, but precautions are needed against attempts to disable features we rely on (specifically ones inferred from us running in 64-bit mode), or guests would equally rely on. I'm therefore unsure whether the mere "named" fact for a feature is a suitable criteria to allow its disabling from the command line. Perhaps a second form of annotation in the public header is needed? Or some minimal feature set to enforce? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
