On 05/12/2018 16:17, Jan Beulich wrote:
> Even if unlikely, donate_page() should not ignore the possible need to
> obtain a domain reference. To make people look more closely when they
> add new uses of domain_adjust_tot_pages(), force its return value to be
> checked. This in turn requires a benign change to assign_pages().
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
This is very weird code to read. It is a side effect of the ABI, and it
appears we do have this style used elsewhere.
Therefore, Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
However, I think this would be improved if we had helpers along the
lines of "bool domain_{add,remove}_pages()" where the boolean return
indicated whether you needed to play with the domain reference count.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
