On 27/12/2018 15:56, Roger Pau Monne wrote: > This implies there's no need to forcefully reserve the VGA MMIO > region, since the memory map provided will be correct. > > Reported-by: Andrew Cooper <andrew.coop...@citrix.com> > Signed-off-by: Roger Pau Monné <roger....@cirix.com> > --- > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> > --- > xen/arch/x86/e820.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c > index 7c5b85118f..5e46d4ec53 100644 > --- a/xen/arch/x86/e820.c > +++ b/xen/arch/x86/e820.c > @@ -537,11 +537,12 @@ static void __init machine_specific_memory_setup(struct > e820map *raw) > > reserve_dmi_region(); > > - /* > - * Some BIOSes claim RAM in the 640k - 1M region. > - * Not right. Fix it up. > - */ > - reserve_vga_region(); > + if ( !xen_guest )
Having thought on this some more, how about using !cpu_has_hypervisor here? Booting PVH under Xen isn't the only case where we won't have a legacy VGA range. HyperV gen-2 VMs are the next most obvious candidate. ~Andrew > + /* > + * Some BIOSes claim RAM in the 640k - 1M region. > + * Not right. Fix it up. > + */ > + reserve_vga_region(); > > top_of_ram = mtrr_top_of_ram(); > if ( top_of_ram ) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
