On Mon, Dec 31, 2018 at 05:34:25PM +0000, Andrew Cooper wrote: > A NT_GNU_BUILD_ID with namesz longer than 4 will cause the strncmp() to use > bytes in adjacent stringtable entries. > > Instead, check for namesz exactly equal to 4, and use memcmp() with an > explicit size. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
This LGTM: Reviewed-by: Roger Pau Monné <roger....@citrix.com> Albeit I wonder the usefulness of some of the checks performed by this function. I'm not sure the point of the 'n->namesz + n->descsz < n->namesz' check, I assume this is an overflow check. And then 'n->namesz + n->descsz > n_sz - sizeof(*n)' should rather be 'n->namesz + n->descsz != n_sz - sizeof(*n)' I think. Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
