On Wed, 2019-01-02 at 13:43 +0000, Wei Liu wrote: > On Fri, Dec 28, 2018 at 08:42:41PM +0200, Petre Pircalabu wrote: > > > > > > define all_sources > > - find include/ arch/ common/ tests/ -name "*.[hcsS]" > > + find include/ arch/ common/ tests/ monitor/ -name "*.[hcsS]" > > endef > > Not a maintainer of xtf, but I find this code placement strange. If > "monitor" is a just yet one category of tests, why is it not placed > under tests/ ? Here (in the src root dir) the monitor subdirectory contains the common code which will be reused for all tests. > > > > > .PHONY: cscope > > diff --git a/build/common.mk b/build/common.mk > > index b786ddf..1ec0fa4 100644 > > --- a/build/common.mk > > +++ b/build/common.mk > > @@ -1,4 +1,4 @@ > > -ALL_CATEGORIES := special functional xsa utility in- > > development > > +ALL_CATEGORIES := special functional xsa utility in- > > development monitor > > You use "monitor" here but "host" in previous patch. They don't > match. > > Wei. The "monitor" test class is a compound test which executes in paralel a "clasic" xtf test (loads DomU and runs to completion) and a "host" test which runs an executable on Dom0. The final result is computed by examining both exit codes. In build/common.mk only the "monitor" class is added to ALL_CATEGORIES, because, at least for now, I don't have an use-case for a "host" only test.
Hope it clarifies the difference, Petre _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
