> -----Original Message----- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 07 January 2019 15:48 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com>; xen-devel@lists.xenproject.org; Roger > Pau Monne <roger....@citrix.com>; Jan Beulich <jbeul...@suse.com>; Andrew > Cooper <andrew.coop...@citrix.com> > Subject: Re: [PATCH 5/8] viridian: use viridian_map/unmap_guest_page() for > reference tsc page > > On Mon, Jan 07, 2019 at 03:35:41PM +0000, Paul Durrant wrote: > [...] > > > > > const struct viridian_page *vp); > > > > > -void viridian_map_guest_page(struct vcpu *v, struct viridian_page > > > *vp); > > > > > +void viridian_map_guest_page(struct domain *d, struct > viridian_page > > > > *vp); > > > > > > > > Since you modify this anyway, can you constify struct domain? > > > > > > > > > > Yes, I guess that should be do-able now that the viridian_page is in a > > > separate allocation unit. > > > > Alas, no. The call to get_page_from_gfn() takes a non-const struct > domain pointer, and I'm not opening that can of worms. Does your R-b still > stand? > > Yes.
Cool. Thanks :-) Paul > > Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
