On 2/5/19 10:09 AM, Norbert Manthey wrote:
> A pointer mismatch has been reported when compiling with the
> compiler goto-gcc of the bounded model checker CBMC.
> To keep trace entry size independent of the compiler implementation,
> use the available p2mt variable for the access, and update the
> trace record independenly.
>
> Fixes: 9a779e4f (Implement SVM specific part for Nested Virtualization)
>
> Signed-off-by: Norbert Manthey <[email protected]>

Reviewed-by: Boris Ostrovsky <[email protected]>

>
> ---
>
> Notes:
>     v2: keep type, use local variable in function call and
>
>  xen/arch/x86/hvm/svm/svm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1800,8 +1800,9 @@ static void svm_do_nested_pgfault(struct vcpu *v,
>          p2m = p2m_get_p2m(v);
>          _d.gpa = gpa;
>          _d.qualification = 0;
> -        mfn = __get_gfn_type_access(p2m, gfn, &_d.p2mt, &p2ma, 0, NULL, 0);
> +        mfn = __get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 0, NULL, 0);
>          _d.mfn = mfn_x(mfn);
> +        _d.p2mt = p2mt;
>          
>          __trace_var(TRC_HVM_NPF, 0, sizeof(_d), &_d);
>      }


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to