> -----Original Message----- > From: Jan Beulich [mailto:[email protected]] > Sent: 08 March 2019 16:47 > To: Paul Durrant <[email protected]> > Cc: Andrew Cooper <[email protected]>; Roger Pau Monne > <[email protected]>; Wei Liu > <[email protected]>; Jun Nakajima <[email protected]>; Kevin Tian > <[email protected]>; xen- > devel <[email protected]> > Subject: Re: [PATCH 4/6] x86: stop handling MSR_IA32_XSS save/restore in > implementation code > > >>> On 07.01.19 at 13:02, <[email protected]> wrote: > > --- a/xen/arch/x86/msr.c > > +++ b/xen/arch/x86/msr.c > > @@ -164,6 +164,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t > > *val) > > > > break; > > > > + case MSR_IA32_XSS: > > + if ( !is_hvm_domain(d) || !cp->xstate.xsaves ) > > Why the is_hvm_domain() check here and below?
Only there because the older code was HVM-specific. > The CPUID policy bit > alone should properly reflect things, and there should be no change > needed here if we decided to support XSAVES also for PV guests. With > them dropped > Reviewed-by: Jan Beulich <[email protected]> Ok. Thanks, Paul > > Jan > _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
