> So this is the 3rd variant of v2 that you've sent, without making it clear > what the difference is. I suppose you've addressed my one remaining > cosmetic request and added my R-b, but we should be at v4 then.
Yes. Since these are all style change, I kept the version number 2. Sorry for the confusion. Kind Regards Xin(Talons) ________________________________________ From: Jan Beulich <[email protected]> Sent: Friday, March 29, 2019 7:08 PM To: Xin Li Cc: Andrew Cooper; Igor Druzhinin; Sergey Dyasli; Xin Li (Talons); [email protected] Subject: Re: [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized string >>> On 29.03.19 at 04:28, <[email protected]> wrote: > Extend smbios type 2 struct to match specification, add support to > write it when customized string provided and no smbios passed in. > > Signed-off-by: Xin Li <[email protected]> > Reviewed-by: Jan Beulich <[email protected]> > > --- > CC: Jan Beulich <[email protected]> > CC: Igor Druzhinin <[email protected]> > CC: Sergey Dyasli <[email protected]> > CC: Andrew Cooper <[email protected]> > > v2 > 1: write the struct if any of the strings is provided > 2: add contained_handles as flexible array member > 3: update commit message and fix style issue So this is the 3rd variant of v2 that you've sent, without making it clear what the difference is. I suppose you've addressed my one remaining cosmetic request and added my R-b, but we should be at v4 then. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
