>>> On 04.04.19 at 22:26, <andrew.coop...@citrix.com> wrote:
> These helpers each fill in a single cpu_devs[] pointer, and since c/s
> 00b4f4d0f "x86/cpuid: Drop get_cpu_vendor() completely", this array is read
> exactly once on boot.
>
> Delete the hooks and cpu_devs[], and have early_cpu_detect() pick the
> appropriate cpu_dev structure directly.
>
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>
with one remark:
> @@ -687,10 +689,6 @@ static cpumask_t cpu_initialized;
>
> void __init early_cpu_init(void)
> {
> - intel_cpu_init();
> - amd_init_cpu();
> - centaur_init_cpu();
> - shanghai_init_cpu();
> early_cpu_detect();
> }
I think this function should then go away as well, unless you have
plans to put new stuff into it. To avoid modifying the caller,
perhaps best to simply renamed early_cpu_detect()? My R-b
stands with this change, if you decide to fold it in.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
