Hi,
On 5/6/19 1:48 PM, Andrii Anisov wrote:
+ /* Sanity check when removing a page. */
+ else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) != 0 )
Shouldn't it be `(flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0` ? As I
understand from the patch 04, we do remove a page when we do unset both
flags.
Hmmm, yes. I will update in the next version.
BTW, I would suggest patches reordering in this series. This patch
should go right after the patch 04, where you introduce those flags.
Because here you implement their usage. But somewhy you inserted an
unrelated change in between.
It is not unrelated, the patch is necessary to make this patch works.
Otherwise you will hit the ASSERT(mfn_eq(mfn, INVALID_MFN)) after one
iteration.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
