>>> On 07.05.19 at 18:15, <george.dun...@citrix.com> wrote: > On 5/2/19 7:58 AM, Jan Beulich wrote: >> This is what both callers of guest_physmap_add_page() in memory.c want >> (for the !paging_mode_translate() case), and it is also what both >> callers in gnttab_transfer() need (but have been lacking). The other >> (x86-specific) callers are all HVM-only, and hence unaffected by this >> change. > > Sorry, what's going on here?
I guess that's a Jan-wrote-an-unparsable-description-once-again question? 1) The two callers in common/memory.c currently call set_gpfn_from_mfn() themselves, so moving the call into guest_physmap_add_page() helps tidy their code. 2) The two callers in common/grant_table.c fail to make that call alongside the one to guest_physmap_add_page(), so will actually get fixed by the change. 3) Other callers are HVM only and are hence unaffected by a change to the function's !paging_mode_translate() part. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
