On 08/05/2019 18:35, George Dunlap wrote: > On 5/6/19 7:56 AM, Juergen Gross wrote: >> In order to prepare core- and socket-scheduling use a new struct >> sched_item instead of struct vcpu for interfaces of the different >> schedulers. >> >> Rename the per-scheduler functions insert_vcpu and remove_vcpu to >> insert_item and remove_item to reflect the change of the parameter. >> In the schedulers rename local functions switched to sched_item, too. >> >> For now this new struct will contain a vcpu pointer only and is >> allocated on the stack. This will be changed later. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > Oy, I realize this comment is going to be somewhat painful, but...
I hope I didn't scream out too loud... ;-) > 'item' really seems like the wrong word here. To me 'item' always means > one thing; whereas what you're planning on doing is grouping together > vcpus to schedule together; which would mean "unit" (as in, a military > unit). > > I realize changing it here probably means also changing it in the next > 43 patches as well. Only about 1000 lines to change. TBH, replacing "item" with "unit" is doable via sed. Doing the same with (as Dario suggested) "entity" is more painful, as I would need to check coding style (line length, indentation) manually afterwards. So Dario, would you be fine with "unit"? This might save me some hours of work. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
