>>> On 08.05.19 at 15:24, <paul.durr...@citrix.com> wrote: > It's not vendor specific so it shouldn't really be there.
Perhaps, but this needs better justification: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -2372,10 +2372,6 @@ static int __init vtd_setup(void) > P(iommu_hap_pt_share, "Shared EPT tables"); > #undef P > > - ret = scan_pci_devices(); > - if ( ret ) > - goto error; > - > ret = init_vtd_hw(); Even after some looking around, it's not obvious to me that the latter call doesn't depend on PCI devices being known, more specifically segment 0's bus2bridge[] having been filled. Nor can I tell whether there would be some noticeable misbehavior (prior to any guests starting) if there was a dependency and it got broken by the re- ordering. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
