The patch resolves 'xencov' crashes in case of Aarch64. All the .init.* sections are stripped after boot, it means that anything in .init.data cannot be accessed anymore. The build system explicitly compiles any .init binary without gcov option. The problem is coming from libfdt and libelf. The entire library is moved to .init using: $(OBJCOPY) $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@ So we need to tell the top Makefile to filter out libfdt and libelf.
Reported-by: Viktor Mitin <[email protected]> Suggested-by: Julien Grall <[email protected]> Signed-off-by: Viktor Mitin <[email protected]> Acked-by: Andrew Cooper <[email protected]> Reviewed-by: Wei Liu <[email protected]> Tested-by: Viktor Mitin <[email protected]> --- Changes from v1: - coverage: filtered out libelf as well --- xen/common/libelf/Makefile | 1 + xen/common/libfdt/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/xen/common/libelf/Makefile b/xen/common/libelf/Makefile index 5bf8f764f1..3d9e38f27e 100644 --- a/xen/common/libelf/Makefile +++ b/xen/common/libelf/Makefile @@ -1,4 +1,5 @@ obj-bin-y := libelf.o +nocov-y += libelf.o SECTIONS := text data $(SPECIAL_DATA_SECTIONS) diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile index d81f54b6b8..c075bbf546 100644 --- a/xen/common/libfdt/Makefile +++ b/xen/common/libfdt/Makefile @@ -3,6 +3,7 @@ include Makefile.libfdt SECTIONS := text data $(SPECIAL_DATA_SECTIONS) obj-y += libfdt.o +nocov-y += libfdt.o CFLAGS += -I$(BASEDIR)/include/xen/libfdt/ -- 2.17.1 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
