Hi Alistair,
On 17/05/2019 23:01, Alistair Francis wrote:
On Fri, May 17, 2019 at 1:46 AM Julien Grall <julien.gr...@arm.com> wrote:
On 16/05/2019 20:30, Alistair Francis wrote:
On Thu, May 16, 2019 at 3:32 AM Jan Beulich <jbeul...@suse.com> wrote:
On 16.05.19 at 02:02, <alistair.fran...@wdc.com> wrote:
Make the asm/vpl011.h dependent on the ARM architecture.
But we only have x86 and Arm right now. A word more about
your motivation would help.
As the code currently is no one can add another architecture. This is
just a general fixup as assuming Xen will only ever support two archs
seems strange.
At which point, wouldn't it be better to avoid #ifdef ARCH in common code?
Instead, we could provide arch helper and/or more meaning CONFIG name.
I'm not sure if the arch helpers are any easier to understand. Maybe
that is worth looking into, at the moment though I still think it
makes sense to fix this #ifdef.
Well, I don't think we would want an #elseif defined(CONFIG_NEW_ARCH) for adding
your new architecture specific include. This is defeating the purpose of common
code.
In this case, the code using the header is protected by
CONFIG_SBSA_VUART_CONSOLE. So I would use that instead of CONFIG_ARM.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
