>>> On 20.05.19 at 19:20, <julien.gr...@arm.com> wrote: >> --- a/xen/drivers/char/console.c >> +++ b/xen/drivers/char/console.c >> @@ -36,7 +36,7 @@ >> #ifdef CONFIG_X86 >> #include <xen/consoled.h> >> #include <asm/guest.h> >> -#else >> +#elif CONFIG_SBSA_VUART_CONSOLE >> #include <asm/vpl011.h> >> #endif > > This is a bit odds to require !CONFIG_X86 && CONFIG_SBSA_VUART_CONSOLE but > the > > code is only protected with the second part. > > How about: > > #endif > #ifdef CONFIG_SBSA_VUART_CONSOLE > ... > #endif > > ?
+1 - doing so will also save me from complaining about the missing defined(). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
