On 28/05/2019 14:44, Tamas K Lengyel wrote: >> * Improvements to domain creation (v2) >> - Andrew Cooper > Hi Andrew, > could you point me to a git branch where you have this work? I'm > experimenting with some stuff and would like to see what your work in > this area touches.
There is essentially nothing which isn't already in staging. Suffice it to say that MDS got in the way of continuing that work. The next task on the list is to make the vcpu/domain destroy paths idempotent, then reimplement the create paths by just returning out of the top of the call tree with an error, and having the top level call destroy. This avoids having two different sets of destruction logic which aren't quite identical. With that in place, I can move the vcpu allocation loop into domain_create() after which it will be impossible to find a domain by ID and trip over some NULL vcpu pointers. If you are introducing or adjusting allocation/deallocation logic, please make the deallocation idempotent, and ideally use the deallocate function to clean up from a failed allocate. There will be some tree-wide refactoring at some point in the future which moves everything into place. Until then, have at it. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
