On 07/06/2019 14:13, Jan Beulich wrote: >>>> On 07.06.19 at 14:20, <andrew.coop...@citrix.com> wrote: >> "adjust system domain creation (and call it earlier on x86)" didn't account >> for the fact that domain_create() depends on XSM already being set up. >> >> Therefore, domain_create() follows xsm_ops->alloc_security_domain() which is >> offset 0 from a NULL pointer, meaning that we execute the 16bit IVT until >> happening to explode in __x86_indirect_thunk_rax(). >> >> There is nothing very interesting which xsm_multiboot_init() more than >> allocating memory, which means it is safe to move earlier during setup. > The last sentence looks somewhat odd to me (the "which" in particular). > Perhaps you could rephrase that?
Oops - I meant "very interesting that xsm_multiboot_init() does more" > Reviewed-by: Jan Beulich <jbeul...@suse.com> Thanks. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
