Hi,

On 6/18/19 11:23 AM, Jan Beulich wrote:
On 17.06.19 at 20:50, <sstabell...@kernel.org> wrote:
Also change srat_region_mask to uint64_t as it is used to store the
return value of pdx_init_mask. uint64_t is always greater or equal to
u64.

I am a bit confused with the last sentence. In which instance, uint64_t would be greater to u64? Aren't they meant to both encode a 64-bit value?


Signed-off-by: Stefano Stabellini <stefa...@xilinx.com>

Non-Arm bits
Acked-by: Jan Beulich <jbeul...@suse.com>
but could you make the title sound less like it's an actual change
to the function return type? Also it's not just its return type
you change.

To move this series forward, how about the following commit message:

"xen: Replace u64 with uint64_t in pdx_init_mask() and callers

Xen is phasing out the use of u64 in favor of uint64_t.

Therefore, the instance of u64 in the pdx_init_mask() (and the callers) are now replaced with uint64_t.

Take the opportunity to also modify srat_region_mask as this is used to store the result of pdx_init_mask().
"

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to