>>> On 26.06.19 at 15:55, <roger....@citrix.com> wrote: > Kconfig makes heavy use of non-literals as format strings, disable > compiler warnings since this is expected usage.
I've never seen any with any version of gcc - are there more aspects to be mentioned here? > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > --- > Cc: Doug Goldstein <car...@cardoe.com> > --- > xen/tools/kconfig/Makefile.kconfig | 5 +++++ > 1 file changed, 5 insertions(+) You Cc list looks to be too short for this change. > --- a/xen/tools/kconfig/Makefile.kconfig > +++ b/xen/tools/kconfig/Makefile.kconfig > @@ -43,6 +43,11 @@ FORCE: > # Sets toolchain binaries to use > include $(XEN_ROOT)/config/$(shell uname -s).mk > > +# Disable format warnings, kconfig makes heavy use of non-literal format > +# strings. > +HOSTCFLAGS += -Wno-format > +HOSTCXXFLAGS += -Wno-format But this disables far more warnings than ones for non-literal format strings, at least afaict. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
