Hi,

On 6/26/19 7:51 PM, Stefano Stabellini wrote:
On Mon, 10 Jun 2019, Julien Grall wrote:
setup_fixmap() will setup the fixmap in the boot page tables in order to
use earlyprintk and also update the register x23 holding the address to
the UART.

However, secondary CPUs are switching to the runtime page tables before
using the earlyprintk again. So settting up the fixmap in the boot pages
tables is pointless.

Typo: settting

ok.


Also, you could add that it is "impossible" to find ourselves in the
position of needing earlyprintk for secondary CPUs before the runtime
page tables are up, because it is done right after in the boot sequence.

It is kind of implied by the comment and the code below. But I can clearly state it.


Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to