On 15.07.2019 11:17, Paul Durrant wrote:
> The _PGC_allocated flag is set on a page when it is assigned to a domain
> along with an initial reference count of at least 1. To clear this
> 'allocation' reference it is necessary to test-and-clear _PGC_allocated and
> then only drop the reference if the test-and-clear succeeds. This is open-
> coded in many places. It is also unsafe to test-and-clear _PGC_allocated
> unless the caller holds an additional reference.
> 
> This patch adds a helper function, put_page_alloc_ref(), to replace all the
> open-coded test-and-clear/put_page occurrences and incorporates in that a
> BUG_ON() an additional page reference not being held.

This last sentence reads somewhat strange to me - are there words
missing and/or mis-ordered?

> Signed-off-by: Paul Durrant <paul.durr...@citrix.com>

With the commit message aspect clarified
Acked-by: Jan Beulich <jbeul...@suse.com>

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to