On 8/25/18 1:21 AM, Dario Faggioli wrote: > If a pCPU has been/is being offlined, we don't want it to be neither > assigned to any pCPU, nor in the wait list.
I take it the first `pCPU` should be `vCPU`? Also, English grammar agreement is funny: `neither` needs to agree with `nor`, but the two do *not* agree with the original verb. That is, the sentence should say: "...we want it to be neither assigned to pCPU, nor in the wait list". Both here and in the comment. The other thing is, from a "developmental purity" point of view, I think this series technically has a regression in the middle: cpu offline / online stops working between patch 2 and patch 4. But I'm inclined in this case not to worry too much. :-) Everything else looks good. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
