On 16/07/2019 11:16, Paul Durrant wrote:
> +int iommu_group_assign(struct pci_dev *pdev, void *arg)
> +{
> + const struct iommu_ops *ops = iommu_get_ops();
> + int id;
> + struct iommu_group *grp;
> +
> + if ( !ops->get_device_group_id )
> + return 0;
> +
> + id = ops->get_device_group_id(pdev->seg, pdev->bus, pdev->devfn);
> + if ( id < 0 )
> + return -ENODATA;
> +
> + grp = get_iommu_group(id);
> + if ( !grp )
> + return -ENOMEM;
> +
> + if ( iommu_verbose )
> + printk(XENLOG_INFO "Assign %04x:%02x:%02x.%u -> IOMMU group %x\n",
No unadorned hex numbers please. This is a recipe for confusion during
debugging.
Either %#x, or %u, and needs to be fixed on commit if we go with that route.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
