On 17/07/2019 15:08, Roger Pau Monné wrote: > Hello, > > As part of some PCI related cleanup I'm doing, which includes > expanding the usage of pci_sbdf_t, I'm also planning to add a custom > printf formatter for pci_sbdf_t [0], so that a SBDF can be printed > without having to specify four formatters (and pass four parameters) > each time (%04x:%02x:%02x.%u). > > There's been some debate on the previous version about whether the > formatter should be %pp or %op, and I would like to settle on one of > them before sending a new version:
I am firmly opposed to overloading %o. Nothing about PCI coordinates has anything to do with octal representation; its mostly hex. And for the record, I'm firmly opposed to overloading %[xuid] as well. %p is the only formatter which has magic overloading so far, and avoiding gaining a second would be of substantial value when it comes to reading the code. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
