On 7/19/19 12:01 PM, George Dunlap wrote: > On 7/19/19 8:34 AM, Nicolas Belouin wrote: >> >> On 7/18/19 11:54 PM, George Dunlap wrote: >>> The Go bindings for libxl miss functions from libxl_utils, let's start >>> with the simple libxl_domid_to_name and its counterpart >>> libxl_name_to_domid. >>> >>> NB that C.GoString() will return "" if it's passed a NULL; see >>> https://github.com/golang/go/issues/32734#issuecomment-506835432 >>> >>> Signed-off-by: Nicolas Belouin <[email protected]> >>> Signed-off-by: George Dunlap <[email protected]> >>> --- >>> v3: >>> - Wire into build system >>> - Add reference to C.GoString() handling NULL to commit message >>> >>> Nicolas, could you test to see if this actually works for you? >> Tested it, it works. >> >> I must confess I do not use that import path as the new modules mechanism >> introduced in Go1.11 downloads and compile a versioned copy of every >> dependency per project, and this behavior is incompatible with the build >> system used here. > Also -- I can't check this in without somebody acking my changes; and > you're the most obvious person to do so. :-) > > -George I successfully tested your changes so consider them as acked.
Nicolas _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
