Hi Jan, All, On Thu, Jul 18, 2019 at 4:38 PM Jan Beulich <jbeul...@suse.com> wrote:
> >> But you're actively breaking Xen style here (and below). > > > > I don't see any mention of style restrictions regarding this in > > CODING_STYLE. If there is, I would prefer changing that so we can > > automate style checks which IMHO are the biggest waste of everyone's > > time to do manually. > > ./CODING_STYLE fails to mention many aspects of what we do everywhere. > Almost any attempt of updating it has failed for me in the past, often > due to entire lack of responses on patches (in other cases also because > of people disagreeing). Despite you being the maintainer of the file I > strongly think you shouldn't actively break style that's in line with > large swathes of code elsewhere. The example above demonstrates the common situation about Xen code style rules. Agree with you that ./CODING_STYLE should be improved by adding explicit rules. So all the formatting aspects can be addressed explicitly. IMHO there should not be any implicit 'non-written' code formatting rules. In other cases, it will be really hard to automate code formatting checks. Thanks _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
