On 26.07.2019 15:33, Roger Pau Monne wrote:
> Include config/$(OS).mk which contains the default values for the
> toolchain variables. This removes the need to pass HOST{CC/CXX} as
> parameters from the high level make target or to default them to
> gcc/g++ if unset.From this description I thought reviewing would be straightforward. However, ... > --- a/xen/tools/kconfig/Makefile.kconfig > +++ b/xen/tools/kconfig/Makefile.kconfig > @@ -35,15 +35,14 @@ KBUILD_DEFCONFIG := $(ARCH)_defconfig > # provide our shell > CONFIG_SHELL := $(SHELL) > > -# provide the host compiler > -HOSTCC ?= gcc > -HOSTCXX ?= g++ > - > # force target > PHONY += FORCE > > FORCE: > > +# Sets toolchain binaries to use > +include $(XEN_ROOT)/config/$(shell uname -s).mk > + > # include the original Makefile and Makefile.host from Linux > include $(src)/Makefile > include $(src)/Makefile.host ... neither the make file here nor the two ones included (in context above) include any other file (afaics) that would lead to HOSTCC being defined. And nothing under $(XEN_ROOT)/config/ looks to define it either. I guess I'm missing something, as I'm sure this is working for you. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
