On 30/07/2019 09:58, Jan Beulich wrote: > On 29.07.2019 14:12, Andrew Cooper wrote: >> Rework nodes_addr() into nodemask_bits() and change the indirection to match >> its cpumask_bits() counterpart, and update the caller. >> >> Use NODEMASK_PR() to fix up one opencoded access into nodemask.bits in >> dump_domains(). >> >> Signed-off-by: Andrew Cooper <[email protected]> > Reviewed-by: Jan Beulich <[email protected]> > albeit I think that ... > >> @@ -58,6 +58,15 @@ >> #include <xen/numa.h> >> >> typedef struct { DECLARE_BITMAP(bits, MAX_NUMNODES); } nodemask_t; >> + >> +/* >> + * printf arguments for a nodemask. Shorthand for using '%*pb[l]' when >> + * printing a nodemask. >> + */ >> +#define NODEMASK_PR(src) MAX_NUMNODES, nodemask_bits(src) >> + >> +#define nodemask_bits(src) ((src)->bits) > ... it would be nice if nodemask_bits() was defined before its first > use, no matter that such ordering is irrelevant for macros.
In this case, I decided that having NODEMASK_PR() closer to the nodemask_t is more important, overall. In practice, they are adjacent and remain so at the end of the series. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
