On 07.08.2019 16:31, Juergen Gross wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -53,6 +53,7 @@ config SPINLOCK_DEBUG > > config LOCK_PROFILE > bool "Lock Profiling" > + select SPINLOCK_DEBUG > ---help--- > Lock profiling allows you to see how often locks are taken and > blocked. > You can use serial console to print (and reset) using 'l' and 'L'
In which case, for sensible user experience, the selected option should come after this one. The way it is now afaict there'll be a prompt for SPINLOCK_DEBUG, the user may say "no", just to find that because of saying "yes" here it'll be turned on anyway. Whereas with switched ordering there'll be no prompt for the debug option at all (again afaict) if the profiling option was set to "yes". Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
