On 08.08.2019 16:10, Julien Grall wrote: > On 08/08/2019 14:51, Jan Beulich wrote: >> On 05.08.2019 15:29, Julien Grall wrote: >>> --- a/xen/include/xen/video.h >>> +++ b/xen/include/xen/video.h >>> @@ -13,11 +13,11 @@ >>> #ifdef CONFIG_VIDEO >>> void video_init(void); >>> -extern void (*video_puts)(const char *); >>> +extern void (*video_puts)(const char *, size_t nr); >>> void video_endboot(void); >>> #else >>> #define video_init() ((void)0) >>> -#define video_puts(s) ((void)0) >>> +#define video_puts(s, nr) ((void)0) >> >> While I don't think there's overly much risk of "s" getting an >> argument with side effects passed, I think that for "nr" the >> risk is there. May I ask that you evaluate both here, just in >> case? > > Are you happy with the following code (Not yet compiled!): > > #define video_ptus(s, nr) ((void)(s), (void)(nr))
With s/ptus/puts/ - sure. A static inline might be another (even better) option. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
