On 14/08/2019 13:00, Wei Liu wrote: > On Wed, Aug 14, 2019 at 11:44:04AM +0100, Andrew Cooper wrote: > [...] >> diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h >> index 22dc795eea..35705441ff 100644 >> --- a/xen/include/asm-x86/config.h >> +++ b/xen/include/asm-x86/config.h >> @@ -56,6 +56,11 @@ >> #define GLOBAL(name) \ >> .globl name; \ >> name: >> + >> +#define ENDDATA(name) \ >> + .type name, STT_OBJECT; \ > Isn't the correct syntax > > .type name STT_OBJECT; > > ? > > The comma shouldn't be there according to as manual.
Huh. I'd not even noticed that. We use a comma with .type everywhere in Xen, including when using STT_* notation rather than the @ variants. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
