Hi Andrew,
On 8/13/19 7:04 PM, Andrew Cooper wrote:
On 24/01/2019 22:10, Andrew Cooper wrote:
On 24/01/2019 21:42, Julien Grall wrote:
Hi Andrew,
On 12/21/18 1:46 PM, Andrew Cooper wrote:
All of this code lives inside CONFIG_PV which means gfn == mfn, and the
fill_ro_mpt() calls clearly show that the value is used untranslated.
Change cr3_gfn to a suitably typed cr3_mfn, and replace
get_page_from_gfn()
with a straight mfn_to_page/get_page sequence, to avoid the
implication that
translation is going on.
No functional change.
Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
---
CC: Jan Beulich <jbeul...@suse.com>
CC: Wei Liu <wei.l...@citrix.com>
CC: Roger Pau Monné <roger....@citrix.com>
CC: Stefano Stabellini <sstabell...@kernel.org>
CC: Julien Grall <julien.gr...@arm.com>
Julien: This should simplify your "xen: Switch parameter in
get_page_from_gfn
to use typesafe gfn" patch. In particular, I did a doubletake at
fill_ro_mpt(_mfn(gfn_x(cr3_gfn))); when reviewing it.
I was looking at updating my patch and remembered you suggested to
rebase on top of this. Do you have any plan to resend the patch?
I'll see if I can find some time tomorrow.
So maybe I was a little off ;) Better late than never I suppose.
I nearly forgot that work :). Can you CC me on the patch when you send
it? I will rebase my work on top of it.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
