On 19/08/2019 19:01, Julien Grall wrote: > Commit b5e6e1ee8da "xen/console: Don't treat NUL character as the end > of the buffer" extended sercon_puts to take the number of character > to print in argument. > > Sadly, a couple of couple of the callers in debugtrace_dump_worker() > were not converted. This result to a build failure when enabling > CONFIG_DEBUG_TRACE. > > Spotted by Travis using randconfig > Signed-off-by: Julien Grall <julien.gr...@arm.com> > --- > xen/drivers/char/console.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index 2c14c2ca73..924d4971ca 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -1185,11 +1185,12 @@ static void debugtrace_dump_worker(void) > > /* Print oldest portion of the ring. */ > ASSERT(debugtrace_buf[debugtrace_bytes - 1] == 0); > - sercon_puts(&debugtrace_buf[debugtrace_prd]); > + sercon_puts(&debugtrace_buf[debugtrace_prd], > + strlen(&debugtrace_buf[debugtrace_prd]));
Isn't this just debugtrace_bytes - debugtrace_prd - 1 ? ~Andrew > > /* Print youngest portion of the ring. */ > debugtrace_buf[debugtrace_prd] = '\0'; > - sercon_puts(&debugtrace_buf[0]); > + sercon_puts(&debugtrace_buf[0], debugtrace_prd); > > memset(debugtrace_buf, '\0', debugtrace_bytes); > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
