> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Saturday, August 17, 2019 1:20 AM > > ...rather than testing the global iommu_enabled flag and ops pointer. > > Now that there is a per-domain flag indicating whether the domain is > permitted to use the IOMMU (which determines whether the ops pointer will > be set), many tests of the global iommu_enabled flag and ops pointer can > be translated into tests of the per-domain flag. Some of the other tests of > purely the global iommu_enabled flag can also be translated into tests of > the per-domain flag. > > NOTE: The comment in iommu_share_p2m_table() is also fixed; > need_iommu() > disappeared some time ago. Also, whilst the style of the 'if' in > flask_iommu_resource_use_perm() is fixed, I have not translated any > instances of u32 into uint32_t to keep consistency. IMO such a > translation would be better done globally for the source module in > a separate patch. > The change in the initialization of the 'hd' variable in iommu_map() > and iommu_unmap() is done to keep the PV shim build happy. Without > this change it will fail to compile with errors of the form: > > iommu.c:361:32: error: unused variable ‘hd’ [-Werror=unused-variable] > const struct domain_iommu *hd = dom_iommu(d); > ^~ > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com>
Reviewed-by: Kevin Tian <kevin.t...@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel