On 27. Aug 2019, at 18:58, Konrad Rzeszutek Wilk <konrad.w...@oracle.com<mailto:konrad.w...@oracle.com>> wrote:
On August 27, 2019 4:46:17 AM EDT, Pawel Wieczorkiewicz <wipa...@amazon.de<mailto:wipa...@amazon.de>> wrote: By default, in the quiescing zone, a hotpatch payload is applied with apply_payload() and reverted with revert_payload() functions. Both of the functions receive the payload struct pointer as a parameter. The functions are also a place where standard 'load' and 'unload' module hooks are executed. To increase hotpatching system's agility and provide more flexiable long-term hotpatch solution, allow to overwrite the default apply and revert action functions with hook-like supplied alternatives. The alternative functions are optional and the default functions are used by default. Is there sense in having the old ones anymore? We could just remove them altogether and just use the new ones instead from the start? Yes, I believe there is. The old ones represent well-tested, proven way of payload application (or revert) which preserves conservative behavior of the system via enforcing certain assumptions. The old ones cover 99% of the production use cases, so I would insist on keeping them in (at least for now). Later, we could modify livepatch-build-tools to always generate the original apply|revert functions (in a default case) as part of payloads (hooks). But, I would not do it just now. Best Regards, Pawel Wieczorkiewicz Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
