> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 02 September 2019 15:54 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Roger Pau > Monne <roger....@citrix.com>; xen-devel@lists.xenproject.org; Tim (Xen.org) > <t...@xen.org>; WeiLiu > <w...@xen.org> > Subject: Re: [PATCH v7 1/6] x86/domain: remove the 'oos_off' flag > > On 02.09.2019 16:21, Paul Durrant wrote: > > Yes, the hap part stays put. The 'oos_off' part moves to x86 and arm can > > be left alone because it already rejects flags != (hvm | hap). > > But it may better reject the OOS flag _despite_ having only HVM guests, > as long as there's no shadow mode there in the first place. >
The flag will be rejected. As I said (in abbreviated form), the test in the ARM code is: if (config->flags != (XEN_DOMCTL_CDF_hvm_guest | XEN_DOMCTL_CDF_hap) ) error... So, any attempt to set XEN_DOMCTL_CDF_oos_off will already cause an error. Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel