On 05/09/2019 11:32, Jan Beulich wrote: > On 05.09.2019 12:01, Roger Pau Monné wrote: >> On Thu, Sep 05, 2019 at 11:52:59AM +0200, Jan Beulich wrote: >>> On 05.09.2019 11:34, Roger Pau Monne wrote: >>>> Current libxl code will always enable Hardware Assisted Paging (HAP), >>>> expecting that the hypervisor will fallback to shadow if HAP is not >>>> available. With the changes to the domain builder that's not the case >>>> any longer, and the hypervisor will raise an error if HAP is not >>>> available instead of silently falling back to shadow. >>> Would it really be much more involved than the change here to restore >>> silent defaulting to shadow? >> But that would mean that a user having selected hap=1 on the config >> file would get silently defaulted to shadow, which is wrong IMO. > Since you and Andrew agree, so be it. Personally I'd like it better > if "hap=1" didn't prevent a domain from starting on a HAP-incapable > host. I wouldn't mind a warning though.
Behaviour like that could be arranged in libxl, which now has all the requisite pieces. What I'm not happy with is xc_domain_create() asking for a HAP domain and getting silently getting a shadow one. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
