> -----Original Message-----
> From: Roger Pau Monne <roger....@citrix.com>
> Sent: 03 September 2019 17:14
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne <roger....@citrix.com>; Paul Durrant
> <paul.durr...@citrix.com>; Jan Beulich
> <jbeul...@suse.com>; Andrew Cooper <andrew.coop...@citrix.com>; Wei Liu
> <w...@xen.org>
> Subject: [PATCH v2 01/11] ioreq: fix hvm_all_ioreq_servers_add_vcpu fail path
> cleanup
>
> The loop in FOR_EACH_IOREQ_SERVER is backwards hence the cleanup on
> failure needs to be done forwards.
>
> Fixes: 97a5a3e30161 ('x86/hvm/ioreq: maintain an array of ioreq servers
> rather than a list')
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Good spot!
Reviewed-by: Paul Durrant <paul.durr...@citrix.com>
> ---
> Changes since v1:
> - New in this version.
> ---
> xen/arch/x86/hvm/ioreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
> index a79cabb680..692b710b02 100644
> --- a/xen/arch/x86/hvm/ioreq.c
> +++ b/xen/arch/x86/hvm/ioreq.c
> @@ -1195,7 +1195,7 @@ int hvm_all_ioreq_servers_add_vcpu(struct domain *d,
> struct vcpu *v)
> return 0;
>
> fail:
> - while ( id-- != 0 )
> + while ( id++ != MAX_NR_IOREQ_SERVERS )
> {
> s = GET_IOREQ_SERVER(d, id);
>
> --
> 2.22.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
