On Tue, Sep 10, 2019 at 04:40:39PM +0100, Andrew Cooper wrote: > On 10/09/2019 16:25, Roger Pau Monne wrote: > > diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml > > index e544ef84da..a5e77c943a 100644 > > --- a/tools/ocaml/libs/xc/xenctrl.ml > > +++ b/tools/ocaml/libs/xc/xenctrl.ml > > @@ -107,6 +107,7 @@ type physinfo_cap_flag = > > | CAP_HVM > > | CAP_PV > > | CAP_DirectIO > > + | CAP_hap > > HAP is an initialism just like HVM, so definitely should be capitalised.
Funny thing, I had it all caps and then switched to this form to match the sysctl define (XEN_SYSCTL_PHYSCAP_hap). Would you like me to resend with all caps? Thanks, Roger. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
