> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 12 September 2019 17:03 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: xen-devel@lists.xenproject.org; Julien Grall <julien.gr...@arm.com>; > Andrew Cooper > <andrew.coop...@citrix.com>; George Dunlap <george.dun...@citrix.com>; Ian > Jackson > <ian.jack...@citrix.com>; Stefano Stabellini <sstabell...@kernel.org>; Konrad > Rzeszutek Wilk > <konrad.w...@oracle.com>; Tim (Xen.org) <t...@xen.org>; Wei Liu <w...@xen.org> > Subject: Re: [PATCH] public/xen.h: update the comment explaining 'Wallclock > time' > > On 12.09.2019 16:05, Paul Durrant wrote: > > Since commit 0629adfd80e "Actually set a HVM domain's time offset when it > > sets the RTC", the comment in the public header has been misleading, since > > it claims that wallclock time is only updated by control software. > > Moreover, the comments stating that wc_sec and wc_nsec are seconds and > > nanoseconds (respectively) in UTC since the Unix epoch are bogus. Their > > values are adjusted by the domain's time_offset_seconds value, which is > > updated by a guest write to the emulated RTC and hence the wallclock > > timezone is under guest control. > > > > This patch attempts to bring the comment in line with reality whilst > > keeping it reasonably short. > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > Acked-by: Jan Beulich <jbeul...@suse.com> > (preferably with the typo fixed that Jürgen pointed out; easily > done while committing)
OK. Thanks, Paul _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
