On 16/09/2019 13:56, Paul Durrant wrote: >> -----Original Message----- >> From: Andrew Cooper <andrew.coop...@citrix.com> >> Sent: 16 September 2019 13:48 >> To: Paul Durrant <paul.durr...@citrix.com>; Xen-devel >> <xen-devel@lists.xenproject.org> >> Cc: Jan Beulich <jbeul...@suse.com>; Wei Liu <w...@xen.org>; Roger Pau Monne >> <roger....@citrix.com> >> Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message >> >> On 15/09/2019 12:51, Paul Durrant wrote: >>>> -----Original Message----- >>>> From: Andrew Cooper <andrew.coop...@citrix.com> >>>> Sent: 13 September 2019 17:04 >>>> To: Xen-devel <xen-devel@lists.xenproject.org> >>>> Cc: Andrew Cooper <andrew.coop...@citrix.com>; Jan Beulich >>>> <jbeul...@suse.com>; Wei Liu >> <w...@xen.org>; >>>> Roger Pau Monne <roger....@citrix.com>; Paul Durrant >>>> <paul.durr...@citrix.com> >>>> Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message >>>> >>>> Message such as: >>>> >>>> (XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204 >>>> >>>> have confused many people into thinking the the problem is a bug in the >>>> viridian code. The prefix was intended to signify the use of the viridian >>>> crash-reporting interface. >>>> >>>> Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to >>>> non-xen-developers trying to interpret the message. >>> This is a message that is peculiar to Windows VMs, so how about "Windows VM >>> CRASH"? >> I presume you mean particular, but no - it isn't windows which is the >> exclusive user of this interface. Linux has a driver to use it when >> running under HyperV. > Hmm, that's a bit odd. I thought the crash codes are Windows specific. > Perhaps they can be distinguished in some way.
Linux sets its own guest OS identifier, which is some function of HV_LINUX_VENDOR_ID. > All the same, the log line needs to lead people to some way of decoding the > magic numbers I think. How about: > > "VIRIDIAN REPORTED CRASH" > > ? That is still just as confusing to read. There is no way to decode the numbers without knowing what OS is running, and simply saying "Viridian" doesn't help with that. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
