Anthony PERARD writes ("[PATCH 30/35] libxl_pci: Use ev_qmp for pci_remove"):
> This patch also replaces the use of
> libxl__wait_for_device_model_deprecated() by its equivalent
> without the need for a thread.
> 
> Signed-off-by: Anthony PERARD <[email protected]>
> ---
> 
> Notes:
>     In do_pci_remove, instead of using a poll loop { ev_timer ; query-pci },
>     it could be possible to listen to events sent by QEMU via QMP; in order
>     to wait for the passthrough pci device to be removed from QEMU.
>     (possible improvement)

Can you please move this into a comment in the code ?

With that change made:

Acked-by: Ian Jackson <[email protected]>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to