On 17.09.2019 21:35, Andrew Cooper wrote: > On 17/09/2019 07:15, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -1004,6 +1004,13 @@ static int hvm_load_cpu_ctxt(struct doma >> return -EINVAL; >> } >> >> + if ( ctxt.cr3 >> d->arch.cpuid->extd.maxphysaddr ) >> + { >> + printk(XENLOG_G_ERR "HVM%d restore: bad CR3 %#" PRIx64 "\n", >> + d->domain_id, ctxt.cr3); >> + return X86EMUL_EXCEPTION; > > -EINVAL, surely?
Oh, indeed. Thanks for spotting. > Everything else LGTM (although I guess it depends on the previous > patch?) It does, yes. > so with this fixed, Reviewed-by: Andrew Cooper > <andrew.coop...@citrix.com> Thanks. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel